-
Notifications
You must be signed in to change notification settings - Fork 1
Add AutoNode testing framework for ROSA HCP clusters (PR #5686) #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add complete Account Roles display with all rosa list account-roles fields - Implement scrollable table format with role prefix, type, version, managed status - Add realistic account roles data across multiple prefixes (fri, melserng, wed) - Create Account Roles button for new role provisioning - Add Operator Roles section with complete table display and create functionality - Reorganize UI structure: move Manage ROSA HCP Clusters below Configure ROSA HCP Resources - Implement collapsible Configure My Credentials/Environment section - Remove CAPI/CAPA Test Automation title and system activity widgets - Move role overview information to helpful tooltips - Enhance table content visibility with full scrollable field display - Improve user experience with comprehensive ROSA resource management 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
• Simplify button and widget labels for better UX - Changed "Configure My Credentials/Environment" to "My Credentials" - Changed "User Configuration Summary" to "My Credentials" - Removed "HCP" from "Configure ROSA HCP Resources" to "Configure ROSA Resources" - Removed redundant "Configure" prefix from credentials button • Enhance copy functionality across configuration widgets - Added copy buttons for all configuration values in sidebar widgets - Implemented individual copy functionality for subnet information - Added "copy all subnets" functionality for bulk operations - Enhanced user experience with clipboard integration • Clean up messaging and remove redundant elements - Removed "👋 Your Environment Configuration:" header text - Updated automation ready message with exclamation marks for emphasis - Removed redundant success message box to reduce visual clutter - Streamlined interface for cleaner, more focused user experience • Fix JSX syntax errors and improve component structure - Resolved multiple JSX closing tag mismatches - Fixed React Fragment wrapping for conditional elements - Improved component stability and compilation reliability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Merge conflicts resolved maintaining UI improvements: - Simplified button text: "My Credentials" instead of "Configure My Credentials/Environment" - Updated configuration section headers - Removed redundant "Configure" text from buttons - Maintained proper JSX structure and React component functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Made all section titles clickable for expand/collapse functionality: • Account Roles section now toggles content visibility • Operator Roles section now toggles content visibility • OIDC Configuration section now toggles content visibility • Subnets section now toggles content visibility - Removed duplicate "Configure ROSA Resources" section to eliminate confusion - Added hover effects and cursor pointer styling for better UX - Wrapped section content in conditional rendering based on collapsed state - Used unique section identifiers to avoid conflicts with existing sections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Merged feature branch enhancements with main branch updates: - Preserved clickable section titles with onClick handlers and hover effects - Maintained proper "Configure ROSA Resources" section with purple theme - Ensured proper "Manage ROSA HCP Clusters" section with orange theme - Removed duplicate sections to maintain clean UI structure - Kept all collapsible functionality and interactive features 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This commit adds comprehensive testing infrastructure for the AutoNode (Karpenter) feature introduced in cluster-api-provider-aws PR #5686. ## New Features ### Configuration Templates - rosa-control-plane-autonode-enabled.yaml: Cluster template with AutoNode enabled - rosa-control-plane-autonode-disabled.yaml: Baseline template for comparison testing - vars/user_vars_autonode_example.yml: Complete configuration example ### Ansible Automation - tasks/validate_autonode_setup.yml: Pre-flight validation for IAM roles and prerequisites - tasks/create_rosa_control_plane_autonode.yml: Enhanced cluster creation with AutoNode support - create_rosa_hcp_cluster_with_autonode.yaml: Main playbook for AutoNode cluster creation ### End-to-End Testing - end2end_tests_autonode.yaml: Comprehensive test suite for AutoNode functionality - tasks/autonode_test_scenario.yml: Individual test scenario execution - tasks/generate_autonode_test_report.yml: Detailed test reporting with JSON/Markdown output - tasks/cleanup_autonode_test_resources.yml: Automated cleanup of test resources ### Documentation - AUTONODE_TESTING_GUIDE.md: Complete testing guide with troubleshooting ## Testing Capabilities - AutoNode enabled/disabled cluster creation - Karpenter IAM role validation - Automatic node scaling verification - End-to-end cluster lifecycle testing - Comprehensive test reporting - Automated resource cleanup This enables testing of the Karpenter integration feature for ROSA HCP clusters through the existing automation-capi framework. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive testing infrastructure for the AutoNode (Karpenter) feature introduced in cluster-api-provider-aws PR #5686.
Features Added
🧪 Testing Framework
📋 Configuration Templates
rosa-control-plane-autonode-enabled.yaml- Cluster with AutoNode/Karpenter enabledrosa-control-plane-autonode-disabled.yaml- Baseline cluster for comparisonvars/user_vars_autonode_example.yml- Complete configuration example🤖 Ansible Automation
tasks/validate_autonode_setup.yml- Pre-flight validationcreate_rosa_hcp_cluster_with_autonode.yaml- Enhanced cluster creation playbookend2end_tests_autonode.yaml- Full test suite execution📚 Documentation
AUTONODE_TESTING_GUIDE.md- Complete testing guide with troubleshootingWhat is AutoNode?
AutoNode enables ROSA HCP clusters to use Karpenter for automatic node scaling instead of traditional machine pools. Benefits include:
Testing Scenarios
AutoNode Enabled Testing
AutoNode Disabled Testing
Validation Testing
Usage
Quick Start
Individual Testing
Prerequisites
Required Setup
KARPENTER_IAM_PERMISSIONS.md)Example IAM Role ARN
Test Reports
The testing framework generates:
results/autonode-tests/autonode-test-report-<timestamp>.mdresults/autonode-tests/autonode-test-results-<timestamp>.jsonresults/autonode-tests/cleanup-report-<timestamp>.mdBenefits for automation-capi
Files Changed
Next Steps
Related: cluster-api-provider-aws PR #5686
🤖 Generated with Claude Code